-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
update _checkdesk_session cookie permissions to entire domain (#1973)
* [CV2-4007] Set check-api session cookie based on environment Set check-api session cookie based on SSM value --------- Co-authored-by: Skye Bender-deMoll <[email protected]>
- Loading branch information
Showing
3 changed files
with
46 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,8 @@ | ||
# Be sure to restart your server when you modify this file. | ||
|
||
Rails.application.config.session_store :cookie_store, key: '_checkdesk_session' | ||
# Retrieve the session key and domain based on the environment using CheckConfig. | ||
cookie_key = CheckConfig.get('session_store_key', '_checkdesk_session') | ||
domain_setting = CheckConfig.get('session_store_domain', Rails.env.development? ? 'localhost' : 'checkmedia.org') | ||
|
||
# Configure the session store with the dynamically obtained session key and domain. | ||
Rails.application.config.session_store :cookie_store, key: cookie_key, domain: domain_setting |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
require 'test_helper' | ||
|
||
class SessionStoreTest < ActiveSupport::TestCase | ||
def with_environment(env) | ||
original_env = Rails.env | ||
Rails.singleton_class.class_eval do | ||
define_method(:env) { ActiveSupport::StringInquirer.new(env) } | ||
end | ||
yield | ||
ensure | ||
Rails.singleton_class.class_eval do | ||
define_method(:env) { original_env } | ||
end | ||
end | ||
|
||
test "session store configuration with default key and domain when config values are not set" do | ||
with_environment('production') do | ||
stub_configs({ 'session_store_key' => nil, 'session_store_domain' => nil }) do | ||
load Rails.root.join('config/initializers/session_store.rb') | ||
assert_equal ActionDispatch::Session::CookieStore, Rails.application.config.session_store | ||
assert_equal '_checkdesk_session', Rails.application.config.session_options[:key] | ||
assert_equal '.checkmedia.org', Rails.application.config.session_options[:domain] | ||
end | ||
end | ||
end | ||
|
||
test "session store configuration with overriding key and domain in config" do | ||
with_environment('production') do | ||
stub_configs({ 'session_store_key' => '_checkdesk_session_qa', 'session_store_domain' => 'qa.checkmedia.org' }) do | ||
load Rails.root.join('config/initializers/session_store.rb') | ||
assert_equal ActionDispatch::Session::CookieStore, Rails.application.config.session_store | ||
assert_equal '_checkdesk_session_qa', Rails.application.config.session_options[:key] | ||
assert_equal 'qa.checkmedia.org', Rails.application.config.session_options[:domain] | ||
end | ||
end | ||
end | ||
end |