remove debug messages

meedan · Jul 7, 2021 · 9dfa7f0 · 9dfa7f0
1 parent b8e43c2
commit 9dfa7f0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/.github/workflows/ci-test-pr.yml b/.github/workflows/ci-test-pr.yml
@@ -129,7 +129,7 @@ jobs:
         -e GITHUB_JOB_NAME=${{ env.GITHUB_JOB_NAME }} \
         -e GITHUB_RUN_ID=${{ env.GITHUB_RUN_ID }} \
         -e CC_TEST_REPORTER_ID=${{ env.CC_TEST_REPORTER_ID }} \
-        -e GIT_COMMITTED_AT=${GIT_COMMITTED_AT}\
+        -e GIT_COMMITTED_AT=${GIT_COMMITTED_AT} \
         api test/test-coverage.sh
 
 
@@ -179,17 +179,13 @@ jobs:
         CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
         GIT_COMMIT_SHA: ${{ github.sha }}
         GIT_BRANCH: ${{ github.ref }}
-        GITHUB_JOB_NAME: unit-tests
-        GITHUB_RUN_ID: ${{ github.run_id }}
       run: |
         GIT_COMMITTED_AT=$(git log -1 --format=%ct)
         docker-compose exec -T \
         -e GIT_COMMIT_SHA=${{ env.GIT_COMMIT_SHA }} \
         -e GIT_BRANCH=${{ env.GIT_BRANCH }} \
-        -e GITHUB_JOB_NAME=${{ env.GITHUB_JOB_NAME }} \
-        -e GITHUB_RUN_ID=${{ env.GITHUB_RUN_ID }} \
         -e CC_TEST_REPORTER_ID=${{ env.CC_TEST_REPORTER_ID }} \
-        -e GIT_COMMITTED_AT=${GIT_COMMITTED_AT}\
+        -e GIT_COMMITTED_AT=${GIT_COMMITTED_AT} \
         api test/test-coverage.sh
 
   cleanup-and-notify:
@@ -211,7 +207,7 @@ jobs:
         aws-region: eu-west-1
 
     - name: Upload Coverage
-      id: run-unit-tests
+      id: upload-coverage
       env:
         CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
         GIT_COMMIT_SHA: ${{ github.sha }}
@@ -225,7 +221,7 @@ jobs:
         -e GITHUB_JOB_NAME=${{ env.GITHUB_JOB_NAME }} \
         -e GITHUB_RUN_ID=${{ env.GITHUB_RUN_ID }} \
         -e CC_TEST_REPORTER_ID=${{ env.CC_TEST_REPORTER_ID }} \
-        -e GIT_COMMITTED_AT=${GIT_COMMITTED_AT}\
+        -e GIT_COMMITTED_AT=${GIT_COMMITTED_AT} \
         api test/upload-coverage.sh
 
     - name: Notify Slack

diff --git a/test/test-coverage.sh b/test/test-coverage.sh
@@ -8,10 +8,9 @@ git clone https://github.com/codeclimate/test-reporter /tmp/go/src/github.com/co
 
 curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2.zip"
 unzip awscliv2.zip
-sudo ./aws/install
+./aws/install
 rm -r aws/
 rm awscliv2.zip
-pwd
 
 # format coverage
 # ./test/format-coverage.sh
@@ -22,7 +21,6 @@ elif [ "$GITHUB_JOB_NAME" == "functional-tests" ] ; then
 fi
 
 echo "Uploading coverage report to S3..."
-ls .
 ls -ahl coverage/
 ./test/cc-test-reporter format-coverage -t simplecov --output coverage/codeclimate.$PATTERN.json ../coverage/.resultset.json
 /usr/local/bin/aws s3 cp coverage/codeclimate.$PATTERN.json s3://check-api-travis/codeclimate/meedan/check-api/$GITHUB_RUN_ID/codeclimate.$PATTERN.json