Fallback to custom title with previous value if item title gets blank.

If an item has the title field set to claim title or fact-check title and one of those are deleted, then in order to avoid that the title gets blank, the title field is set to "custom_title" and the value is the previous title value. Reference: CV2-3986.
meedan · Jan 5, 2024 · ab47a35 · ab47a35
1 parent eb0dc5b
commit ab47a35
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/app/models/concerns/project_media_cached_fields.rb b/app/models/concerns/project_media_cached_fields.rb
@@ -546,7 +546,10 @@ def recalculate_description
     end
 
     def recalculate_title
-      self.get_title
+      title = self.get_title
+      # Always save the title as a custom title so we can fallback to it in case the title gets blank (for example, title_field is claim title and claim is deleted)
+      title.blank? ? self.update_column(:title_field, 'custom_title') : self.update_column(:custom_title, title)
+      title.blank? ? self.custom_title&.to_s : title
     end
 
     def recalculate_status

diff --git a/app/models/concerns/project_media_getters.rb b/app/models/concerns/project_media_getters.rb
@@ -150,7 +150,7 @@ def get_title
       custom_title: :custom_title,
       pinned_media_id: :media_slug,
       claim_title: :claim_description_content,
-      fact_check_title: :fact_check_title
+      fact_check_title: :recalculate_fact_check_title
     }
     title_field = self.title_field&.to_sym
     if !title_field.blank? && title_mapping.keys.include?(title_field)