Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not submit as unconfirmed media a text with just a few words. #1684

Merged
merged 3 commits into from
Oct 7, 2023

Conversation

caiosba
Copy link
Contributor

@caiosba caiosba commented Oct 5, 2023

Description

In that case, the request should still be saved, but associated with the workspace, not with a text media.

Fixes CV2-3784.

How has this been tested?

I implemented two new unit tests for this.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

In that case, the request should still be saved, but associated with the workspace, not with a text media.

Fixes CV2-3784.
@codeclimate
Copy link

codeclimate bot commented Oct 7, 2023

Code Climate has analyzed commit 2d9855e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@caiosba caiosba merged commit a7de721 into develop Oct 7, 2023
8 checks passed
@caiosba caiosba deleted the feature/CV2-3784-no-short-unconfirmed-media branch October 7, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants