Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cv2 4095 shared feed cluster data model api backend #1799

Closed

Conversation

melsawy
Copy link
Contributor

@melsawy melsawy commented Feb 12, 2024

Description

Apply data model

  • A Cluster belongs to a Feed (many-to-one)
  • A Feed has many Cluster’s (one-to-many)
  • A ProjectMedia has and belongs to many Cluster’s (many-to-many)
  • Permissions: The feed permissions apply to its clusters
  • set a first cluster item as center
  • Change cluster cached field logic to match new changes
  • Fix tests

References: CV2-4095

How has this been tested?

Depend on automated tests.

Things to pay attention to during code review

Please describe parts of the change that require extra attention during code review, for example:

  • File FFFF, line LL: This refactoring does this and this. Is it consistent with how it’s implemented elsewhere?
  • Etc.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 87916 lines exceeds the maximum allowed for the inline comments feature.

@melsawy melsawy marked this pull request as ready for review February 13, 2024 16:44
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 87868 lines exceeds the maximum allowed for the inline comments feature.

@caiosba
Copy link
Contributor

caiosba commented Feb 13, 2024

Thanks @melsawy - I won't review/merge, but just take the work from here.

@caiosba caiosba self-assigned this Feb 13, 2024
Copy link

codeclimate bot commented Feb 15, 2024

Code Climate has analyzed commit 2d21f16 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 90.3% (100% is the threshold).

This pull request will bring the total coverage in the repository to 99.9% (0.0% change).

View more on Code Climate.

@caiosba
Copy link
Contributor

caiosba commented Feb 18, 2024

@melsawy thanks, feel free to delete this PR/branch after you review #1802 - I incorporated these changes there.

@melsawy melsawy closed this Feb 19, 2024
@melsawy melsawy deleted the CV2-4095-shared-feed-cluster-data-model-api-backend branch February 19, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants