Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only deliver fact-check title and URL for Facebook Messenger tipline search results #1801

Merged

Conversation

caiosba
Copy link
Contributor

@caiosba caiosba commented Feb 15, 2024

Description

Messenger changed the way it formats messages... now it breaks a single long message into smaller messages, so for long fact-checks, messages can be delivered out of order, which is super weird (like, a title in one message, the link in another message, etc.). This commit changes how tipline search results are delivered for Facebook Messenger: no fact-check summary, only title and URL.

Fixes CV2-4287.

How has this been tested?

Captura de tela de 2024-02-15 08-38-56

Things to pay attention to during code review

The change should affect ONLY Facebook Messenger.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

…search results.

Messenger changed the way it formats messages... now it breaks a single long message into smaller messages, so for long fact-checks, messages can be delivered out of order, which is super weird (like, a title in one message, the link in another message, etc.). This commit changes how tipline search results are delivered for Facebook Messenger: no fact-check summary, only title and URL.

Fixes CV2-4287.
Copy link

codeclimate bot commented Feb 15, 2024

Code Climate has analyzed commit f80dac9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@DGaffney DGaffney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@caiosba caiosba merged commit 16f3e2b into develop Feb 15, 2024
4 of 7 checks passed
@caiosba caiosba deleted the fix/CV2-4287-only-title-and-url-for-messenger-search-results branch February 15, 2024 15:22
caiosba added a commit that referenced this pull request Feb 15, 2024
…search results. (#1801)

Messenger changed the way it formats messages... now it breaks a single long message into smaller messages, so for long fact-checks, messages can be delivered out of order, which is super weird (like, a title in one message, the link in another message, etc.). This commit changes how tipline search results are delivered for Facebook Messenger: no fact-check summary, only title and URL.

Fixes CV2-4287.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants