Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply content warning screens for banned users #1807

Merged
merged 7 commits into from
Mar 28, 2024

Conversation

jayjay-w
Copy link
Contributor

@jayjay-w jayjay-w commented Feb 26, 2024

Description

When a user is banned and their submissions are still being consumed by other users, we will now automatically apply content warning screens to their ProjectMedia.

References: CV2-3582

How has this been tested?

  • Confirmed that banned users' content will be marked as 'Spam'

Things to pay attention to during code review

Ban a user and confirm that all of their project media will be flagged as 'Spam'

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@jayjay-w jayjay-w force-pushed the CV2-3582-content-warning-for-banned-users branch from fc0aaea to 8006cc4 Compare March 4, 2024 10:43
@jayjay-w jayjay-w force-pushed the CV2-3582-content-warning-for-banned-users branch 2 times, most recently from 75730d1 to e2aaeed Compare March 19, 2024 15:26
@jayjay-w jayjay-w marked this pull request as ready for review March 22, 2024 06:41
@jayjay-w jayjay-w marked this pull request as draft March 22, 2024 06:52
@jayjay-w jayjay-w force-pushed the CV2-3582-content-warning-for-banned-users branch from 5372deb to 4aff25d Compare March 24, 2024 20:31
@jayjay-w jayjay-w marked this pull request as ready for review March 25, 2024 09:23
@caiosba caiosba requested a review from melsawy March 25, 2024 10:54
Copy link
Contributor

@melsawy melsawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayjay-w still have uncovered lines
app/models/concerns/team_rules.rb: 164
lmk if you need a help to add a missing tests

@jayjay-w jayjay-w force-pushed the CV2-3582-content-warning-for-banned-users branch from d58c371 to 4aff25d Compare March 25, 2024 21:32
@jayjay-w jayjay-w force-pushed the CV2-3582-content-warning-for-banned-users branch from 4aff25d to d3570fb Compare March 28, 2024 10:22
Copy link

codeclimate bot commented Mar 28, 2024

Code Climate has analyzed commit d3570fb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@jayjay-w
Copy link
Contributor Author

@jayjay-w still have uncovered lines app/models/concerns/team_rules.rb: 164 lmk if you need a help to add a missing tests

@melsawy this is now fixed. There are no coverage issues. Please let me know if it is OK now.

@jayjay-w jayjay-w merged commit 5a4224a into develop Mar 28, 2024
8 checks passed
@jayjay-w jayjay-w deleted the CV2-3582-content-warning-for-banned-users branch March 28, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants