Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-2648: migrate tipline requests #1811

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

melsawy
Copy link
Contributor

@melsawy melsawy commented Feb 28, 2024

Description

Expose the code for TiplineRequest migration so we can proceed with migration before live deployment.
PR contains:

  • The database migration
  • Rake task check:migrate:migrate_tipline_requests
  • Empty TiplineRequest model:

Also I updated the rake task to accept pre-defined keyword for slug(i.e rails check:migrate:migrate_tipline_requests['slug:custom_slugs]) by this way the rake task will allow user to type team slugs using terminal.

References: CV2-2648

How has this been tested?

Tested locally against live DB using specific team.

Things to pay attention to during code review

Please describe parts of the change that require extra attention during code review, for example:

  • File FFFF, line LL: This refactoring does this and this. Is it consistent with how it’s implemented elsewhere?
  • Etc.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@melsawy melsawy merged commit 2f00193 into master Feb 28, 2024
7 checks passed
@melsawy melsawy deleted the feature/CV2-2648-migrate-from-master-branch branch February 28, 2024 14:53
melsawy added a commit that referenced this pull request Feb 28, 2024
melsawy added a commit that referenced this pull request Feb 29, 2024
* CV2-2648: migrate tipline requests (#1811)

* CV2-2648: add setVal for TiplineRequest table

* CV2-2648: migrate missing items
caiosba added a commit that referenced this pull request Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants