-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feed clusters: Rake task completion and refactoring. #1816
Conversation
Code Climate has analyzed commit fb98a53 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (100% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
cluster_items << updated_cluster_attributes | ||
# Update cluster | ||
# FIXME: Update clusters in batches | ||
cluster.update_columns(updated_cluster_attributes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@caiosba I have a question why do you prefer updating each cluster instead of bulk-update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't prefer, but it was not working, so I fixed it the easiest way. I filed a ticket to improve the performance but in a way that it works as expected.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Description
This PR implements the final version of the feed clusters rake task.
Reference: CV2-4172.
How has this been tested?
Executed locally.
Checklist