Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed clusters: Rake task completion and refactoring. #1816

Merged
merged 5 commits into from
Mar 3, 2024

Conversation

caiosba
Copy link
Contributor

@caiosba caiosba commented Mar 3, 2024

Description

This PR implements the final version of the feed clusters rake task.

Reference: CV2-4172.

How has this been tested?

Executed locally.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@caiosba caiosba requested review from melsawy and DGaffney as code owners March 3, 2024 00:28
@caiosba caiosba removed the request for review from DGaffney March 3, 2024 00:37
Copy link

codeclimate bot commented Mar 3, 2024

Code Climate has analyzed commit fb98a53 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

cluster_items << updated_cluster_attributes
# Update cluster
# FIXME: Update clusters in batches
cluster.update_columns(updated_cluster_attributes)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caiosba I have a question why do you prefer updating each cluster instead of bulk-update?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't prefer, but it was not working, so I fixed it the easiest way. I filed a ticket to improve the performance but in a way that it works as expected.

@melsawy melsawy merged commit 00e7074 into develop Mar 3, 2024
8 checks passed
@melsawy melsawy deleted the feature/CV2-4172-parse-output-file-rake-task branch March 3, 2024 08:11
Copy link

sentry-io bot commented Mar 3, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Aws::S3::Errors::AccessDenied: Access Denied check:khousheh:rebuild View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants