Delete old tipline request and fix sentry issue #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 23f4499 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (100% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
caiosba
reviewed
Mar 4, 2024
| @@ -50,7 +50,7 @@ def text_contains_keyword(text, value) | |||
|
|
|||
| def get_smooch_message(pm) | |||
| smooch_message = pm.smooch_message | |||
| smooch_message.nil? ? pm.tipline_requests.last.smooch_data : smooch_message | |||
| smooch_message.nil? ? pm.tipline_requests.last&.smooch_data : smooch_message | |||
There was a problem hiding this comment.
@melsawy , is the exception happenning for items that are expected to not have an associated TiplineRequest? after the fix, did you test that rules are working for tipline messages?
There was a problem hiding this comment.
@caiosba I depend on our testing to verify this one but also I'll test it manually
There was a problem hiding this comment.
I confirmed locally that it works.
caiosba
approved these changes
Mar 5, 2024
caiosba
pushed a commit
that referenced
this pull request
Mar 5, 2024
* CV2-4351: fix sentry issue * CV2-4352: delete old tipline requests(annotation of type smooch) * CV2-4352: add logs to rake task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References: CV2-4351, CV2-4352
How has this been tested?
Locally against live DB .
Things to pay attention to during code review
Please describe parts of the change that require extra attention during code review, for example:
Checklist