CV2-2357: New UX for update to ToS #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
app/mailers/updated_terms_mailer.rb
Outdated
| @@ -0,0 +1,12 @@ | |||
| class UpdatedTermsMailer < ApplicationMailer | |||
| layout nil | |||
There was a problem hiding this comment.
Use 2 (not 1) spaces for indentation.
app/mailers/updated_terms_mailer.rb
Outdated
| @@ -0,0 +1,12 @@ | |||
| class UpdatedTermsMailer < ApplicationMailer | |||
| layout nil | |||
melsawy
changed the title
caiosba
approved these changes
Mar 6, 2024
app/mailers/updated_terms_mailer.rb
Outdated
|
|
||
| def notify(recipient, name) | ||
| @name = name | ||
| @accept_terms_url = "https://meedan.com/legal/terms-of-service" |
There was a problem hiding this comment.
Question: Why this is hard-coded instead of reading from the configuration key tos_url (https://github.com/meedan/check-api/blob/develop/config/config.yml.example#L70)?
| puts "[#{Time.now}] Done in #{minutes} minutes." | ||
| end | ||
| end | ||
| end |
|
Code Climate has analyzed commit 1adb946 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (100% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Send an email to all Check users notifying them that the ToS have been updated.
References: CV2-2357
How has this been tested?
Implemented automated tests.
Things to pay attention to during code review
Please describe parts of the change that require extra attention during code review, for example:
Checklist