Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add negative feedback to tipline's smooch request type #1820

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

vasconsaurus
Copy link
Contributor

@vasconsaurus vasconsaurus commented Mar 6, 2024

Description

We are going to start working on a feature to filter the tipline request:

  • Filter by items that received positive feedback
  • Filter by items that received negative feedback

When creating the seeds we were not adding the negative feedback (irrelevant_search_result_requests). Before we were adding only: default_requests, timeout_search_requests and relevant_search_result_requests. So this PR changes that.

References: 4309

How has this been tested?

By running the seeds script and checking if the requests type were added.

Things to pay attention to during code review

  • To make it more likely that we will get relevant_search_result_requests and irrelevant_search_result_requests, I added them a few more times to the array in smooch_request_type.
  • The negative feedback is not displayed in the UI.
  • If a request report has been received. That information will show on the UI, you'll be able to see the history on mouseover (if it has a positive or no feedback, again, a negative feedback is not displayed).

Screenshot 2024-03-05 at 16 48 12

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

also added both negative and positive feedback a few more times to the
array so they are more likely to happen.
after updating develop and rebuilding my schema seems out of date?
Copy link

codeclimate bot commented Mar 6, 2024

Code Climate has analyzed commit 2041d24 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@vasconsaurus
Copy link
Contributor Author

@caiosba I added the schema update just for you to take a look, I can remove it before making the PR ready for review.

@caiosba
Copy link
Contributor

caiosba commented Mar 6, 2024

@caiosba I added the schema update just for you to take a look, I can remove it before making the PR ready for review.

It's fine to merge, I noticed it in a PR from @melsawy too, so it's legit.

@vasconsaurus vasconsaurus marked this pull request as ready for review March 6, 2024 14:24
@vasconsaurus vasconsaurus merged commit 1065234 into develop Mar 6, 2024
8 checks passed
@vasconsaurus vasconsaurus deleted the add-negative-tipline-request-to_seed branch March 26, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants