Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared feed import validation message: Format URLs using Markdown #1897

Merged
merged 2 commits into from
May 22, 2024

Conversation

caiosba
Copy link
Contributor

@caiosba caiosba commented May 22, 2024

Description

When trying to import media from a shared feed that already exist in the target workspace, return the existing item URLs in the error message as Markdown, so they can be better displayed on the frontend.

Reference: CV2-4631.

How has this been tested?

On the frontend side (Check Web branch with same name as this):

Captura de tela de 2024-05-22 15-26-44

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@caiosba
Copy link
Contributor Author

caiosba commented May 22, 2024

Requesting review again because I made some changes to format as per conversation with @brianfleming in the ticket.

@DGaffney
Copy link
Contributor

Just make sure to address test failure before merge!

@caiosba caiosba merged commit dce85fa into develop May 22, 2024
8 checks passed
@caiosba caiosba deleted the fix/CV2-4631-shared-feed-import-validation-message branch May 22, 2024 22:58
caiosba added a commit that referenced this pull request May 23, 2024
)

When trying to import media from a shared feed that already exist in the target workspace, return the existing item URLs in the error message as Markdown, so they can be better displayed on the frontend.

Reference: CV2-4631.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants