Articles data model and API changes #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to list explainers on the frontend side, some changes were needed on the backend. - Title should not be mandatory at the API level but at the model level (and description as well) - Store tags in the Explainer model and keep them in sync with TagText instances - Adding filters, counter, sorting and pagination to the TeamType.articles connection Reference: CV2-4500.
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
app/models/explainer.rb
Outdated
| end | ||
| end | ||
|
|
||
| private |
There was a problem hiding this comment.
Useless private access modifier.
1 task
Some changes for fact-checks data model and API: * Adding tags * Filters and sort Reference: CV2-4145
|
@melsawy can you please review this? |
melsawy
approved these changes
Jun 4, 2024
jayjay-w
approved these changes
Jun 10, 2024
* CV2-4665: index report information in fact check * CV2-4665: fix tests * CV2-4665: migrate fact-check tags and allow filter by report informations(publisher, rating and report status) * CV2-4665: apply PR comments * CV2-4665: add more tests
…into epic/CV2-4441-articles
Some changes to articles API and data model: - It should be possible to create `ClaimDescription` without a `ProjectMedia` - Adding a `team_id` field to `ClaimDescription` - Expose `ClaimDescription.project_media_id` in GraphQL mutations - Adding a new many-to-many relationship between explainers and items, through a new join model `ExplainItem`, and respective GraphQL type and mutations - Expose `FactCheck.rating` in GraphQL mutations - New GraphQL fields for `ProjectMedia`: `fact_check` and `explainers` - New filters for `Team.explainers` GraphQL connection: `standalone` and `text` References: CV2-4441, CV2-4626 and CV2-4627.
Adding an "imported" field to fact-checks. It's automatically set as "true" for fact-checks created by bots. This PR includes: - Database migration - Business logic (set "imported" as "true" for fact-checks created by bots, automatically) - Unit tests - GraphQL API, including filter to TeamType.articles - Rake task to update existing fact-checks Reference: CV2-4882.
* CV2-4901: Sync status value with fact-check rating * CV2-4901: apply PR comment * CV2-4901: fix tests
…ecks (#1956) This creates both standalone claim descriptions and standalone claim descriptions with fact checks. Though only the second is visible in the UI. We also: - verify the fact checks with a random status ('undetermined', 'not_applicable', 'in_progress', 'verified' or 'false') - add a link to half of the standalone fact checks Note: I also had to update how we were verifying and publishing the fact-checks that are related to a project media. It was breaking since now we can have claim_descriptions with nil project_media_id. (check-api/db/seeds.rb: line 333) References: 4880 PR: 1956
…into epic/CV2-4441-articles
|
Code Climate has analyzed commit 8a201eb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (100% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API changes to return filtered and sorted explainers and fact-checks for a given workspace.
Reference: CV2-4441.
Check Web Epic PR: meedan/check-web#1951