Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-4741 increase timeout from one to two minutes #1925

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

DGaffney
Copy link
Contributor

Description

Simple bump from one minute to two minutes for timeout errors in waiting on alegre responses.

References: CV2-4741

How has this been tested?

Not tested yet - should be straightforward

Things to pay attention to during code review

NA

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

Copy link

codeclimate bot commented Jun 12, 2024

Code Climate has analyzed commit b2a6b2c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@DGaffney DGaffney requested a review from caiosba June 12, 2024 22:11
Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@DGaffney DGaffney merged commit 94394bb into develop Jun 12, 2024
8 checks passed
@DGaffney DGaffney deleted the cv2-4741-increase-timeout branch June 12, 2024 22:50
DGaffney added a commit that referenced this pull request Jun 13, 2024
* CV2-4741 increase timeout from one to two minutes

* add CheckConfig for sleep timer
danielevalverde added a commit that referenced this pull request Jun 13, 2024
* Deprecate column picker settings page

Delete the GraphQL field list_columns from TeamType, delete the respective model method and any other dependent code and related tests

Reference: CV2-3920

* Expose projectMedia.fact_check_published_on field (#1922)

* CV2-4741 increase timeout from one to two minutes (#1925)

* CV2-4741 increase timeout from one to two minutes

* add CheckConfig for sleep timer

* fix test

---------

Co-authored-by: Alexandre Amoedo Amorim <[email protected]>
Co-authored-by: Devin Gaffney <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants