CV2-4719 add unique identifier as doc_id at check-api level

[DGaffney]

Description

On Presto, oftentimes we unnecessarily fingerprint the same item several times. With this change, we will plumb a content_hash key along through Check-API to Alegre to Presto, so that Presto can use the key to do an internal lookup against a Redis server to see if we have a recently fingerprinted item with that ID and just return it directly.

References: CV2-4719

How has this been tested?

No tests yet - expanding the data package will very likely cause many test errors, so this first change is to just highlight/record them.

Things to pay attention to during code review

Nothing significant at the Check-API stage, probably.

Checklist

• I have performed a self-review of my own code
• I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
• I have added regression tests, if the PR fixes a bug
• I have added logging, exception reporting, and custom tracing with any additional information required for debugging
• I considered secure coding practices when writing this code. Any security concerns are noted above.
• I have commented my code in hard-to-understand areas, if any
• I have made needed changes to the README
• My changes generate no new warnings
• If I added a third party module, I included a rationale for doing so and followed our current guidelines

[caiosba]

Devin, please add the missing tests.

[DGaffney]

@caiosba will do - the alegre_v2.rb missing lines are obvious, but no idea why bot_user.rb is complaining here, is that upstream of this ticket or am I just not seeing the tie?

app/models/concerns/alegre_v2.rb: 153, 156, 159, 160
app/models/bot_user.rb: 90, 136, 137, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 194, 195, 196, 197, 198, 199, 226, 230, 234, 235, 239, 240, 241, 242, 243, 244, 245, 247, 334, 344, 475

[caiosba]

I think that the BotUser ones are flaky (or not covered because of the other failures).

[DGaffney]

@caiosba sounds good - I'll fix the others first, we'll rerun, then assess

[codeclimate]

Trailing whitespace detected.

[codeclimate]

Code Climate has analyzed commit e295099 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 99.9% (0.0% change).

View more on Code Climate.