Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add italian translations and enable locale #1930

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

amoedoamorim
Copy link
Contributor

Description

Adding italian translations and enabling locale on application.rb

References: CV2-4736

How has this been tested?

Tested on rails console:

irb(main):016:0> I18n.l(Time.now, locale: 'it', format: :long)
=> "19 giugno 2024 17:02"
irb(main):017:0> Bot::Smooch.get_string('privacy_and_purpose', 'it')
=> "Privacy e scopo\n\nBenvenuto al suggerimento di %{team} %{channel}.\n\nPuoi utilizzare questo numero per inviare la tua richiesta di verifica.\n\nI tuoi dati sono al sicuro. Prendiamo sul serio la nostra responsabilità di salvaguardare le tue informazioni personali e di mantenere %{channel} privato e sicuro; non condivideremo, venderemo o utilizzeremo le tue informazioni di identificazione personale (PII) se non per fornire e migliorare questo servizio.\n\nPer rilevare la disinformazione virale il prima possibile in futuro, potremmo condividere contenuti non PII con ricercatori selezionati e partner di verifica dei fatti.\n\nTieni presente che i siti Web a cui ci colleghiamo avranno la propria politica sulla privacy.\n\nSe non vuoi che i tuoi contributi vengano utilizzati in questo lavoro, ti preghiamo di non contribuire al nostro sistema."

Things to pay attention to during code review

Please describe parts of the change that require extra attention during code review, for example:

  • File FFFF, line LL: This refactoring does this and this. Is it consistent with how it’s implemented elsewhere?
  • Etc.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buono

Copy link

codeclimate bot commented Jun 19, 2024

Code Climate has analyzed commit 61cc823 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@amoedoamorim amoedoamorim merged commit 31424c0 into develop Jun 20, 2024
8 checks passed
@amoedoamorim amoedoamorim deleted the feature/CV2-4736-add-italian-to-the-tipline branch June 26, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants