Cv2 4793 identify required workflows #1957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: CHECK-2295.
Reference: CHECK-2295.
Reference: CHECK-2295.
* Data is now per week, from when the feed was created until today * New column for feed type Reference: CHECK-2433.
For media queries, the medias can be stored locally. Additional headers to access the media can be stored in the feed settings. Reference: CHECK-2423.
Fixes CHECK-2423.
Fixes CHECK-2440.
* Total number of requests * Daily * Weekly Reference: CHECK-2455.
New data points: * Average number of conversations per day * Number of messages sent (total, monthly) - not back and forth These should not be available on the dashboards inside Check, just in the statistics.csv file uploaded to S3. Reference: CHECK-2506.
Fixes CHECK-2507.
This is an easy win in terms of performance... it avoids N + 1 performance issues on various GraphQL queries and it's a value that never changes, so we can keep it cached forever essencially. Hopefully fixes CHECK-2491.
Cloud API documentation: https://developers.facebook.com/docs/whatsapp/cloud-api/support/error-codes/ Fixes CHECK-2472.
* Set custom title for file items * Sort feed requests by media type * Better performance (e.g., avoid N + 1 queries problem) for `RequestType` fields `feed` and `media` * Cache feed name for requests * Requests now have title Reference: CHECK-2494.
• Log the responses for all HTTP requests to a request `webhook_url` • Notify Errbit if that response is not 200 Reference: CHECK-2514.
* Read tipline Privacy and Purpose content from Transifex This commit changes the usage of hardcoded privacy and purpose texts from content downloaded from transifex into tipline_string.yml References CHECK-2460 CHECK-2461 * Fix test * CHECK-2460 CHECK-2461 Actually include Arabic and Gujarati strings
* Read tipline Privacy and Purpose content from Transifex This commit changes the usage of hardcoded privacy and purpose texts from content downloaded from transifex into tipline_string.yml References CHECK-2460 CHECK-2461 * Fix test
* CHECK-2437 add language as a parameter to alegre requests * CHECK-2437 of course you should probably return the params
Reference: CHECK-2437.
Fixes CHECK-2530.
…o Alegre" This reverts commit 65e8b6c.
* Fallback to default status is mapped status is not valid (fixes CHECK-2560) * Report to Errbit when an exception happens on a GraphQL request (fixes CHECK-2551)
chinelo-obitube
requested review from
caiosba,
melsawy,
DGaffney and
jayjay-w
as code owners
|
@melsawy can you please take this review? |
|
@chinelo-obitube you can remove the |
|
It will be removed in the next ticket https://meedan.atlassian.net/browse/CV2-4794 after confirmation from @melsawy |
added 3 commits
July 16, 2024 17:06
This reverts commit b99fe6c.
|
closing this PR because of unrelated changes into this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the new workflow for ci-tests to github actions
References: https://meedan.atlassian.net/browse/CV2-4793
How has this been tested?
The pipeline was previously set to run on push to the feature branch as shown here https://github.com/meedan/check-api/actions/runs/9892849970
Things to pay attention to during code review
Please describe parts of the change that require extra attention during code review, for example:
Checklist