Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ci-test-workflow #1958

Merged

Conversation

chinelo-obitube
Copy link
Contributor

@chinelo-obitube chinelo-obitube commented Jul 16, 2024

Description

Adding the new workflow for ci-tests to github actions

References: https://meedan.atlassian.net/browse/CV2-4793

How has this been tested?

The pipeline was previously set to run on push to the feature branch as shown here https://github.com/meedan/check-api/actions/runs/9892849970

Things to pay attention to during code review

Please describe parts of the change that require extra attention during code review, for example:

  • File FFFF, line LL: This refactoring does this and this. Is it consistent with how it’s implemented elsewhere?
  • Etc.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

Copy link

codeclimate bot commented Jul 16, 2024

Code Climate has analyzed commit b1c6422 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 99.9% (0.0% change).

View more on Code Climate.

@caiosba
Copy link
Contributor

caiosba commented Jul 16, 2024

@melsawy can you please take this review?

@chinelo-obitube chinelo-obitube merged commit 757c12e into develop Jul 16, 2024
11 checks passed
@chinelo-obitube chinelo-obitube deleted the cv2-4793-identify-required-workflows-check-api branch August 27, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants