Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-4918: migrate claims without fact-checks #1970

Merged
merged 3 commits into from
Jul 27, 2024

Conversation

melsawy
Copy link
Contributor

@melsawy melsawy commented Jul 25, 2024

Description

Migrate claims without fact-checks.

References: CV2-4918

How has this been tested?

Run rake task against live DB dump locally.

Things to pay attention to during code review

Please describe parts of the change that require extra attention during code review, for example:

  • File FFFF, line LL: This refactoring does this and this. Is it consistent with how it’s implemented elsewhere?
  • Etc.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

print '.'
fc_items = []
cds.each do |cd|
fc_items << { claim_description_id: cd.id, user_id: cd.user_id, created_at: cd.created_at, updated_at: cd.updated_at }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request: Add title: '-' and summary: '-' (and whichever other fields that have model-level validation).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done and also set language with team default language value

@melsawy melsawy requested a review from caiosba July 27, 2024 06:33
@melsawy melsawy merged commit ed1da8e into develop Jul 27, 2024
10 checks passed
@melsawy melsawy deleted the CV2-4918-articles-migrate-claims-without-fact-checks branch July 27, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants