5010 – Fix tag with trailing space error #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a normalization steps but that runs before_validation on TagText. Meaning when we are checking if the tag exists in line 92 from tag.rb, the tag has not been normalized. We look for 'tag', it is not there, we create it. We look for ' tag', it is not there, but once we try to create it, it is normalized, so it becomes 'tag', then we fail to create it, because it already exists. Adding the strip when compating tags fixes this, but I'm not sure if it is the best solution.
|
@caiosba Could you please take a look?
|
vasconsaurus
changed the title
caiosba
reviewed
Aug 2, 2024
app/models/annotations/tag.rb
Outdated
| @@ -89,7 +89,7 @@ def self.run_bulk_create_callbacks(ids_json, pmids_json) | |||
| def get_tag_text_reference | |||
| if self.tag.is_a?(String) | |||
| team_id = self.team&.id | |||
| tag_text = TagText.where(text: self.tag, team_id: team_id).last | |||
| tag_text = TagText.where(text: (self.tag).strip, team_id: team_id).last | |||
There was a problem hiding this comment.
Minor, only FYI: The parenthesis are not needed here.
|
That's a good solution, Manu. And thanks for adding the tests. Were you able to reproduce the same exception in the test, before the fix? |
vasconsaurus
changed the title
vasconsaurus
requested review from
melsawy,
DGaffney and
jayjay-w
as code owners
melsawy
reviewed
Aug 5, 2024
| @@ -89,7 +89,7 @@ def self.run_bulk_create_callbacks(ids_json, pmids_json) | |||
| def get_tag_text_reference | |||
| if self.tag.is_a?(String) | |||
| team_id = self.team&.id | |||
| tag_text = TagText.where(text: self.tag, team_id: team_id).last | |||
| tag_text = TagText.where(text: self.tag.strip, team_id: team_id).last | |||
There was a problem hiding this comment.
Also I suggest to trim database value so we can catch existing one with trailing space
i.e
tag_text = TagText.where(team_id: team_id).where('trim(text) = ?', self.tag.strip).last
There was a problem hiding this comment.
Oh I see that we normalize tag before saving in DB and did self.text.strip.gsub(/^#/, '') so we can skip this comment
melsawy
approved these changes
Aug 5, 2024
caiosba
approved these changes
Aug 5, 2024
DGaffney
pushed a commit
that referenced
this pull request
Aug 7, 2024
When trying to create an imported fact-check that had a tag with a trailing space it would fail (`text has already been taken`).
We have a normalization step but that runs `before_validation` on `TagText`.
So when we are checking if the tag exists in line 92 from `tag.rb`, the tag has not been normalized. This means:
- We look for 'tag', it is not there. We create it.
- We look for ' tag', it is not there. We try to create it, it gets normalized, so it becomes 'tag'. Then we fail to create it,
because it already exists.
Adding the strip when comparing tags fixes this.
Tests
- rails test test/controllers/graphql_controller_12_test.rb:613
- rails test test/models/tag_test.rb:275
References: 5010
PR: 1982
DGaffney
added a commit
that referenced
this pull request
Aug 16, 2024
…1986) * CV2-5011 refactors for making alegre dual purpose on text encoding * first pass on adding tests for new functionality * uncomment line * fix holdover typo * Query fact_check and explainer by id (#1980) * Test syntax fix for docker compose commands. (#1984) * Bump rexml from 3.2.8 to 3.3.3 (#1981) Bumps [rexml](https://github.com/ruby/rexml) from 3.2.8 to 3.3.3. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.2.8...v3.3.3) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Return the previous project media for claim description (#1985) Use case: we may need to update the project media information in the Relay store when it's removed from a claim. Reference: CV2-5000. * Adding new GraphQL field to `ProjectMediaType`: `suggested_main_relationship`. Reference: CV2-5004. * CV2-5002: fix sentry issue (#1978) * CV2-5002: fix sentry issue * CV2-5002: fix tests * Do not rate limit successful login attempts (#1968) When a login attempt is successful, we should not increment the counter for rate limiting. * 5010 – Fix tag with trailing space error (#1982) When trying to create an imported fact-check that had a tag with a trailing space it would fail (`text has already been taken`). We have a normalization step but that runs `before_validation` on `TagText`. So when we are checking if the tag exists in line 92 from `tag.rb`, the tag has not been normalized. This means: - We look for 'tag', it is not there. We create it. - We look for ' tag', it is not there. We try to create it, it gets normalized, so it becomes 'tag'. Then we fail to create it, because it already exists. Adding the strip when comparing tags fixes this. Tests - rails test test/controllers/graphql_controller_12_test.rb:613 - rails test test/models/tag_test.rb:275 References: 5010 PR: 1982 * Ticket #4938: Sort workspaces alphabetically (#1988) * Reverting migration until empty clusterization center issue is actually resolved (#1990) Reference: CV2-4869 * Moving `accessible_teams` from `UserType` to `MeType`. (#1991) This information is only needed for the current user, so, it should be under `MeType`, not `UserType`. References: CV2-4938 and CV2-4704. * Fixing Sidekiq error "ActiveRecord::RecordInvalid: Text has already been taken" --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Alexandre Amoedo Amorim <[email protected]> Co-authored-by: Martin Peck <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Caio Almeida <[email protected]> Co-authored-by: Mohamed El-Sawy <[email protected]> Co-authored-by: Jay Joshua <[email protected]> Co-authored-by: Manu Vasconcelos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When trying to create an imported fact-check that had a tag with a trailing space it would fail (
text has already been taken).We have a normalization step but that runs
before_validationonTagText.So when we are checking if the tag exists in line 92 from
tag.rb, the tag has not been normalized. This means:because it already exists.
Adding the strip when comparing tags fixes this, but I'm not sure if it is the best solution.
References: 5010
How has this been tested?
rails test test/controllers/graphql_controller_12_test.rb:613rails test test/models/tag_test.rb:275Things to pay attention to during code review
Please describe parts of the change that require extra attention during code review, for example:
Checklist