CV2-5011 refactors for making alegre dual purpose on text encoding #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [rexml](https://github.com/ruby/rexml) from 3.2.8 to 3.3.3. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.2.8...v3.3.3) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Use case: we may need to update the project media information in the Relay store when it's removed from a claim. Reference: CV2-5000.
…ionship`. Reference: CV2-5004.
* CV2-5002: fix sentry issue * CV2-5002: fix tests
When a login attempt is successful, we should not increment the counter for rate limiting.
When trying to create an imported fact-check that had a tag with a trailing space it would fail (`text has already been taken`).
We have a normalization step but that runs `before_validation` on `TagText`.
So when we are checking if the tag exists in line 92 from `tag.rb`, the tag has not been normalized. This means:
- We look for 'tag', it is not there. We create it.
- We look for ' tag', it is not there. We try to create it, it gets normalized, so it becomes 'tag'. Then we fail to create it,
because it already exists.
Adding the strip when comparing tags fixes this.
Tests
- rails test test/controllers/graphql_controller_12_test.rb:613
- rails test test/models/tag_test.rb:275
References: 5010
PR: 1982
caiosba
requested changes
Aug 8, 2024
caiosba
approved these changes
Aug 8, 2024
computermacgyver
approved these changes
Aug 14, 2024
…ly resolved (#1990) Reference: CV2-4869
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this ticket, I'm adding functionality for Alegre to serve text encoding responses both in the original, soon-to-be-deprecated way, as well as via presto. Idea is we'll serve both for a bit and slowly work out each individual case to use the new system over time. Insofar as check-api is concerned, we're only slightly modifying
alegre_v2.rbto extend use to text. Will need to add a few unit tests to accommodateReferences: CV2-5011
How has this been tested?
Tested extensively locally, will need to add unit test coverage for new functions.
Things to pay attention to during code review
None in particular
Checklist