Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-5051: Item history updates #1989

Merged
merged 6 commits into from
Aug 15, 2024
Merged

Conversation

melsawy
Copy link
Contributor

@melsawy melsawy commented Aug 13, 2024

Description

Log more actions on item history.

  • Log add/remove Explainer.
  • Remove Explainer logs (no need for this log and it moved to ExplainerItem model)
  • Log remove FactCheck

References: CV2-5051

How has this been tested?

Implemented automated tests.

Things to pay attention to during code review

Please describe parts of the change that require extra attention during code review, for example:

  • File FFFF, line LL: This refactoring does this and this. Is it consistent with how it’s implemented elsewhere?
  • Etc.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@melsawy melsawy marked this pull request as ready for review August 15, 2024 07:41
@melsawy melsawy merged commit 110506e into develop Aug 15, 2024
10 checks passed
@melsawy melsawy deleted the CV2-5051-item-history-updates branch August 15, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants