Export lists #1992
Merged
Export lists #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…igned URL and that expires after X days
melsawy
reviewed
Aug 24, 2024
Comment on lines
+33
to
+37
| csv_string = CSV.generate do |csv| | ||
| self.export_data.each do |row| | ||
| csv << row | ||
| end | ||
| end |
There was a problem hiding this comment.
Just need more details for myself to user csv for do and then use csv << row so what's the expected value for csv_string it will be csv array
There was a problem hiding this comment.
It generates a CSV string, really.
DGaffney
pushed a commit
that referenced
this pull request
Aug 27, 2024
Allow lists (core, custom, search results, articles, filtered or not) to be exported to a CSV file that is sent to e-mail.
- [x] Add an `exportList` GraphQL mutation
- [x] Implement a generic export class that supports media, articles and feeds
- [x] Validate maximum number of results (which is a global configuration key)
- [x] Validate permission
- [x] Create Sidekiq job to export results
- [x] Create a CSV for the export
- [x] Save CSV in S3 using a pre-signed URL that expires after X days ("X" is a global configuration key)
- [x] Add support to MailCatcher
- [x] Send CSV by e-mail
- [x] Automated tests
- [x] Make sure it works for articles as well
- [x] Make sure it works for shared feeds as well
References: CV2-5067 and CV2-4979.
DGaffney
pushed a commit
that referenced
this pull request
Aug 27, 2024
Allow lists (core, custom, search results, articles, filtered or not) to be exported to a CSV file that is sent to e-mail.
- [x] Add an `exportList` GraphQL mutation
- [x] Implement a generic export class that supports media, articles and feeds
- [x] Validate maximum number of results (which is a global configuration key)
- [x] Validate permission
- [x] Create Sidekiq job to export results
- [x] Create a CSV for the export
- [x] Save CSV in S3 using a pre-signed URL that expires after X days ("X" is a global configuration key)
- [x] Add support to MailCatcher
- [x] Send CSV by e-mail
- [x] Automated tests
- [x] Make sure it works for articles as well
- [x] Make sure it works for shared feeds as well
References: CV2-5067 and CV2-4979.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow lists (core, custom, search results, articles, filtered or not) to be exported to a CSV file that is sent to e-mail.
exportListGraphQL mutationReferences: CV2-5067 and CV2-4979.
How has this been tested?
Automated tests implemented for 100% coverage.
Checklist