Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-5087 move Articles side effecting saves to to it via presto #1993

Closed
wants to merge 7 commits into from

Conversation

DGaffney
Copy link
Contributor

Description

Moves article processing to presto vectorization instead of entirely in alegre

References: CV2-5087

How has this been tested?

Not yet tested - changing code first to determine effect of changes then work through necessary changes from there - testing will need to just ensure that articles do in fact get indexed if you send these commands to alegre from check-api

Things to pay attention to during code review

None in particular!

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@DGaffney DGaffney marked this pull request as ready for review August 18, 2024 14:28
Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DGaffney , I suggest we just close this PR since there is a lot of overlap with #1994. And then the PR for CV2-5087 should be the one that includes this line:

::Bot::Alegre.relate_project_media_async(obj.project_media, field)

@DGaffney DGaffney closed this Aug 22, 2024
@DGaffney DGaffney deleted the cv2-5087-articles-to-presto branch August 22, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants