Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Smooch Bot provider when tipline is running both CAPI and Smooch. #2004

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

caiosba
Copy link
Contributor

@caiosba caiosba commented Aug 27, 2024

Fixes CV2-5127.

Description

When a tipline is running both CAPI and Smooch, the get_installation method will set the provider to CAPI. When sending a newsletter, it's necessary to adjust the provider to ZENDESK for people who subscribed to the Smooch newsletter, not the CAPI newsletter.

How has this been tested?

Existing tests should cover this.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

Copy link
Contributor

@melsawy melsawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not forget to fix CC issue

@caiosba
Copy link
Contributor Author

caiosba commented Aug 27, 2024

Please do not forget to fix CC issue

@melsawy , I don't see a CC issue, do you? are you using their browser extension?

@caiosba caiosba merged commit c1c9b20 into develop Aug 27, 2024
10 checks passed
@caiosba caiosba deleted the fix/CV2-5127-smooch-provider-hybrid branch August 27, 2024 15:05
DGaffney pushed a commit that referenced this pull request Aug 27, 2024
caiosba added a commit that referenced this pull request Aug 27, 2024
DGaffney pushed a commit that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants