CV2-5148: Use more inclusive detection of URLs in message text #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URI.regexp.match... only matched fully-qualified urls (i.e., urls need to include http://, https://, or another protocol) Twitter::TwitterText::Extractor.extract_urls recognizes urls without the protocol. This is consistent with how WhatsApp and other platforms parse URLs and more in line with user expectations.
computermacgyver
requested review from
caiosba,
melsawy,
DGaffney and
jayjay-w
as code owners
jayjay-w
approved these changes
Aug 28, 2024
melsawy
approved these changes
Aug 28, 2024
computermacgyver
deleted the
CV2-5148-tweak-what-is-a-url-for-tipline-shortcut
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
URI.regexp.match... only matched fully-qualified urls (i.e., urls need to include http://, https://, or another protocol) . I knew this at the time I did #2011 , but I didn't realize until testing that this was inconsistent with how WhatsApp handles URLs.
The changes in this PR use Twitter::TwitterText::Extractor.extract_urls, which recognizes urls without the protocol. This is consistent with how WhatsApp and more in line with user expectations.
References: CV2-5148
How has this been tested?
Added a unit test for this specific case
Things to pay attention to during code review
N/A
Checklist