Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-5154: remove medias_count from project #2017

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Conversation

melsawy
Copy link
Contributor

@melsawy melsawy commented Sep 3, 2024

Description

Remove medias_count field from Project.

References: CV2-5154

How has this been tested?

Re-run automated tests.

Things to pay attention to during code review

Please describe parts of the change that require extra attention during code review, for example:

  • File FFFF, line LL: This refactoring does this and this. Is it consistent with how it’s implemented elsewhere?
  • Etc.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@melsawy melsawy marked this pull request as ready for review September 3, 2024 14:19
Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @melsawy , did you confirm that Check Web is not using this field?

@melsawy
Copy link
Contributor Author

melsawy commented Sep 3, 2024

Looks good. @melsawy , did you confirm that Check Web is not using this field?

yes I removed this field from check-web and push a PR and it passed and confirmed that items count appear for custom list

@caiosba
Copy link
Contributor

caiosba commented Sep 3, 2024

Awesome!

:shipit:

Copy link
Contributor

@jayjay-w jayjay-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@melsawy melsawy merged commit 62dbb95 into develop Sep 3, 2024
10 checks passed
@melsawy melsawy deleted the CV2-5154-slow-db-query branch September 3, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants