Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for fact-checks should match claim fields too. #2020

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

caiosba
Copy link
Contributor

@caiosba caiosba commented Sep 3, 2024

Description

Now searching for fact-checks can also match the claim fields "description" and "context".

Fixes: CV2-5194.

How has this been tested?

I added a unit test.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

Now searching for fact-checks matches the claim fields "description" and "context".

Fixes: CV2-5194.
Copy link
Contributor

@vasconsaurus vasconsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward to me 🙂

@caiosba caiosba merged commit 0679cb3 into develop Sep 4, 2024
10 checks passed
@caiosba caiosba deleted the fix/CV2-5194-fact-checks-search-matches-claim branch September 4, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants