Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for ecs deploy utility #2022

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Bugfix for ecs deploy utility #2022

merged 2 commits into from
Sep 4, 2024

Conversation

sonoransun
Copy link
Contributor

Description

This fixes an upstream deprecation in the ecs deploy utility.

How has this been tested?

Tested with a deploy into QA via PR branch.

Checklist

  • I have performed a self-review of my own code
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • My changes generate no new warnings

DGaffney
DGaffney approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@DGaffney DGaffney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we dont trigger anything looks :shipit: to me!

@sonoransun sonoransun merged commit 4dcbe5d into develop Sep 4, 2024
10 checks passed
@sonoransun sonoransun deleted the bugfix/ecs-deploy-update branch September 4, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caiosba caiosba caiosba approved these changes

@DGaffney DGaffney DGaffney approved these changes

@melsawy melsawy Awaiting requested review from melsawy melsawy is a code owner

@jayjay-w jayjay-w Awaiting requested review from jayjay-w jayjay-w is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sonoransun @DGaffney @caiosba