CSV-5225: ignore nested documents that exceeds nested_objects_limit #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caiosba
requested changes
Sep 8, 2024
Comment on lines
315
to
320
| # pm_tt2 = pm.annotations('task').select{|t| t.team_task_id == tt2.id}.last | ||
| # pm_tt2.response = { annotation_type: 'task_response_single_choice', set_fields: { response_single_choice: 'ans_aa' }.to_json }.to_json | ||
| # pm_tt2.save! | ||
| # pm_tt3 = pm.annotations('task').select{|t| t.team_task_id == tt3.id}.last | ||
| # pm_tt3.response = { annotation_type: 'task_response_single_choice', set_fields: { response_single_choice: 'ans_aaa' }.to_json }.to_json | ||
| # pm_tt3.save! |
There was a problem hiding this comment.
Why these are commented? If not relevant, can't you just delete them?
| # pm_tt3.save! | ||
| sleep 2 | ||
| es = $repository.find(pm.get_es_doc_id) | ||
| pp es['task_responses'] |
There was a problem hiding this comment.
Please delete this debugging line if you don't need it.
| pm = create_project_media team: team | ||
| stub_configs({ 'nested_objects_limit' => 2 }) do | ||
| # answer single choice | ||
| puts "Start to answer" |
There was a problem hiding this comment.
Please delete this debugging line if you don't need it.
| @@ -82,6 +82,7 @@ def get_fresh_value(data) | |||
|
|
|||
| def add_update_nested_obj(options) | |||
| return if self.disable_es_callbacks || RequestStore.store[:disable_es_callbacks] | |||
| return if options[:op] == 'create' && self.respond_to?(:hit_nested_objects_limit?) && self.hit_nested_objects_limit? | |||
There was a problem hiding this comment.
Question: Only happens when the operation is "create"?
There was a problem hiding this comment.
yes as create add a new object to nested_object
caiosba
approved these changes
Sep 8, 2024
Comment on lines
322
to
323
| # TODO: fix the test | ||
| # assert_equal 2, task_responses.size |
There was a problem hiding this comment.
Good to go once this test is fixed.
melsawy
added a commit
that referenced
this pull request
Sep 9, 2024
…2025) * CSV-5225: ignore nested documents that exceeds nested_objects_limit * CV2-5225: add tests * CV2-5225: cleanup * CV2-5225: apply nested_objects_limit on tags and requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ignore nested documents that exceeds nested_objects_limit which by default
10.000.I limit this condition to tags and requests nested objects.
References: CSV-5225
How has this been tested?
Implemented automated tests.
Things to pay attention to during code review
Please describe parts of the change that require extra attention during code review, for example:
Checklist