-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unknown
type to TaskInfoType
#542
Merged
Merged
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
958968e
Unknown Type Added
postmeback 1154c04
Added tests and additional classes
postmeback c2934b5
Moved file positions
postmeback f966d1f
Merge branch 'main' into main
curquiza 6ce326f
Removed unnecessary files and methods
postmeback ffb8a86
Merge branch 'main' of https://github.com/postmeback/meilisearch-dotnet
postmeback 9f0c618
Merge branch 'main' into main
ahmednfwela 7190f79
Removed unnecessary tests
postmeback 71e432d
Merge branch 'main' of https://github.com/postmeback/meilisearch-dotnet
postmeback 460563d
Changes Done
postmeback bdf0b29
Ran formatter
postmeback 3b84c94
Merge branch 'main' into main
postmeback 41c23fa
Suggested Changes Done
postmeback 88019e8
Merge branch 'main' of https://github.com/postmeback/meilisearch-dotnet
postmeback File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
using System; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this new file is unnecessary |
||
using System.Collections.Generic; | ||
using System.Text; | ||
|
||
namespace Meilisearch.QueryParameters | ||
{ | ||
public class GetTaskQuery | ||
{ | ||
public Guid Uid { get; set; } | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
using System; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this new file is unnecessary |
||
using System.Collections.Generic; | ||
using System.Text; | ||
|
||
namespace Meilisearch.QueryParameters | ||
{ | ||
public class UnknownTaskQuery | ||
{ | ||
public Guid Uid { get; set; } | ||
public TaskInfoType TaskType { get; set; } | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -115,6 +115,7 @@ public enum TaskInfoType | |
TaskCancelation, | ||
SnapshotCreation, | ||
TaskDeletion, | ||
IndexSwap | ||
IndexSwap, | ||
Unknown | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of these are unnecessary