Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tap-msaccess #1663

Merged
merged 23 commits into from
Mar 7, 2024
Merged

Add tap-msaccess #1663

merged 23 commits into from
Mar 7, 2024

Conversation

ReubenFrankel
Copy link
Contributor

@ReubenFrankel ReubenFrankel commented Feb 6, 2024

https://github.com/Matatika/tap-msaccess/releases/tag/v0.1.0

New take on the tap-spreadsheets-anywhere approach: instead of a single plugin that can connect to multiple file systems, break each out into its own plugin with defined settings, in an attempt to make configuration easier for the user.


Adds 5 new plugins (possibly more in the future):

  • tap-msaccess - the "base" plugin with local file system support only
  • tap-msaccess-azure - Azure file system support with known settings
  • tap-msaccess-s3 - S3 file system support with known settings
  • tap-msaccess-http - HTTP file system support
  • tap-msaccess-anywhere - Support for (theoretically) all fsspec backend implementations

Nothing set in stone here yet, so if you have any thoughts or concerns, please raise them!

Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for meltano-hub ready!

Name Link
🔨 Latest commit adc10f3
🔍 Latest deploy log https://app.netlify.com/sites/meltano-hub/deploys/65ea0399051e880009f51819
😎 Deploy Preview https://deploy-preview-1663--meltano-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ReubenFrankel
Copy link
Contributor Author

CI failure seems to be related to sensitive: true invaliding the JSON schema check - should I set it to kind: password for now or ignore assuming that the schema will be updated at some point?

@edgarrmondragon
Copy link
Collaborator

should I set it to kind: password for now or ignore assuming that the schema will be updated at some point?

I think so. Meltano is inject the sensitive: true flag into lock files anyway: https://github.com/meltano/meltano/pull/7874/files#diff-0a49a7859d1fe309fa7e7f789e398c35653bf50c9c18c82e9d7334cd54c0e5feR229

@ReubenFrankel
Copy link
Contributor Author

Looks like there is some similar discussion in #1445 for tap-universal-file.

@edgarrmondragon
Copy link
Collaborator

tap-dbf uses the approach of nested settings, e.g. s3.endpoint_url. That solves the settings problem, but not the packaging extras problem, though ...

@edgarrmondragon
Copy link
Collaborator

This would benefit from #1701

Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ReubenFrankel!

@edgarrmondragon edgarrmondragon merged commit 86f04ea into meltano:main Mar 7, 2024
11 checks passed
@ReubenFrankel ReubenFrankel deleted the tap-msaccess branch March 7, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants