-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insertion of Ulisse Wolf mods #10
Conversation
This pull request is to verify the correct modification of the yaml files so that the mods I developed are already compatible with sc4pack
Update of yaml files related to Fallout Prop Pack. The task of this update is to verify the correct syntax in writing the yaml files
This update should contain all the changes necessary for my mods to work properly with SC4Pack. (Note: Freddy Fazbear's Pizza is still pending update due to the complexity of the mod)
I've updated your branch with a small syntax fix. (Whitespace matters in YAML files.) The Github Action check still finds some problems:
Today, I uploaded detailed documentation on Adding metadata which should help resolve most of these. Let me know if you have questions. |
Corrected the Freddy Fazbear Pizza file with syntax that should be corected
Carried out correction of problems identified during the control phase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a potential difficulty involving Freddy Fazbear's Pizza upload. The ZIP file contains nested ZIP files inside, one for each variant. Nested ZIP files can be extracted, but if the files inside have the same name, they cannot be distinguished in the include
filter.
For example, if multiple ZIP files contain the file Ulisse Wolf - FNAF Sign-0x6534284a-0x904b7d34-0x5276ca26.SC4Desc
, then sc4pac does not know which ZIP file it came from or which variant it belongs to.
This pull request is to verify the correct modification of the yaml files so that the mods I developed are already compatible with sc4pack