Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insertion of Ulisse Wolf mods #10

Merged
merged 10 commits into from
May 23, 2024
Merged

Insertion of Ulisse Wolf mods #10

merged 10 commits into from
May 23, 2024

Conversation

UlisseWolf
Copy link
Contributor

This pull request is to verify the correct modification of the yaml files so that the mods I developed are already compatible with sc4pack

UlisseWolf and others added 5 commits November 21, 2023 21:16
This pull request is to verify the correct modification of the yaml files so that the mods I developed are already compatible with sc4pack
Update of yaml files related to Fallout Prop Pack. The task of this update is to verify the correct syntax in writing the yaml files
This update should contain all the changes necessary for my mods to work properly with SC4Pack. (Note: Freddy Fazbear's Pizza
is still pending update due to the complexity of the mod)
@memo33
Copy link
Owner

memo33 commented Nov 26, 2023

I've updated your branch with a small syntax fix. (Whitespace matters in YAML files.)

The Github Action check still finds some problems:

==> The following packages are referenced, but not defined:
network-addon-mod
sc:vip-girafe-carpack-vol03
===> The following assets are referenced, but not defined:
ulissewolf-fallout-prop-pack-vol1-darknite
ulissewolf-fallout-prop-pack-vol1-maxisnite
ulissewolf-fallout-prop-pack-vol2-darknite
ulissewolf-fallout-prop-pack-vol2-maxisnite
ulissewolf-freddy-fazbears-pizza-darknite-alert
ulissewolf-freddy-fazbears-pizza-maxisnite-alert
ulissewolf-freddy-fazbears-pizza-maxisnite-noalert
===> the following assetIds do not match the naming convention (lowercase alphanumeric hyphenated)
ulissewolf-hybrid-railway-(hrw)-subway-converter
ulissewolf-mediterranean-transport.set-vol-1
===> the following group identifiers do not match the naming convention (lowercase alphanumeric hyphenated)
ulisse wolf
===> the following package names do not match the naming convention (lowercase alphanumeric hyphenated)
mediterranean-transport.set-vol-1
hybrid-railway-(hrw)-subway-converter
Finished with 14 errors.

Today, I uploaded detailed documentation on Adding metadata which should help resolve most of these. Let me know if you have questions.

UlisseWolf and others added 3 commits November 29, 2023 18:58
Corrected the Freddy Fazbear Pizza file with syntax that should be corected
Carried out correction of problems identified during the control phase
Copy link
Owner

@memo33 memo33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a potential difficulty involving Freddy Fazbear's Pizza upload. The ZIP file contains nested ZIP files inside, one for each variant. Nested ZIP files can be extracted, but if the files inside have the same name, they cannot be distinguished in the include filter.

For example, if multiple ZIP files contain the file Ulisse Wolf - FNAF Sign-0x6534284a-0x904b7d34-0x5276ca26.SC4Desc, then sc4pac does not know which ZIP file it came from or which variant it belongs to.

@memo33 memo33 merged commit 212952f into memo33:main May 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants