Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WannGLondon's New York Pack 1 #35

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

sebamarynissen
Copy link
Contributor

@memo33
Copy link
Owner

memo33 commented Nov 1, 2024

For buildings without MN variant, I add a MN variant anyway for compatibility. For example:

assets:
- assetId: "wannglondon-american-rowhomes-1"
variants:
- variant: { nightmode: "standard" }
- variant: { nightmode: "dark" }
dependencies: [ "simfox:day-and-nite-mod" ]

It's just a minor conflict affecting night scenes only.

@sebamarynissen
Copy link
Contributor Author

sebamarynissen commented Nov 1, 2024

Ah thanks, I'll adapt. I didn't remember how it worked. Maybe that you could metnion it in the documentation somehow?

@memo33
Copy link
Owner

memo33 commented Nov 1, 2024

I've added a note to the documentation in c58509f.

@memo33 memo33 merged commit 8140307 into memo33:main Nov 3, 2024
3 checks passed
@sebamarynissen sebamarynissen deleted the feature/new-york-pack-1 branch November 4, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants