Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing images #38

Merged
merged 15 commits into from
Nov 18, 2024
Merged

Add missing images #38

merged 15 commits into from
Nov 18, 2024

Conversation

sebamarynissen
Copy link
Contributor

I was playing a bit with your gui and noticed that the images feature is really nice. Great work on the gui, a new era for SimCity 4 is truly dawning!

Anyway, I noticed that my former uploads contributions did not include any images, so I added them all.

@sebamarynissen
Copy link
Contributor Author

sebamarynissen commented Nov 13, 2024

Not sure why the lastModified dates are suddenly not matching anymore, I generated them automatically form the <datetime> element on the webpage back in the time.

@sebamarynissen
Copy link
Contributor Author

Figured since I had the script to add images to my own contributions, I might as well run it on all files that don't have images yet.

@memo33
Copy link
Owner

memo33 commented Nov 15, 2024

Awesome. Thanks a lot.

Not sure why the lastModified dates are suddenly not matching anymore, I generated them automatically form the <datetime> element on the webpage back in the time.

Simtropolis has recently made a change so that STEX entries show the upload date of the files instead of the last modification date of the STEX description.

This means practically all the dates in our metadata are off. Technically, this is not a problem, as future changes of the STEX files would have newer dates. I didn't update the timestamps so far, as it's going to trigger a re-download of all the STEX files. Though, to avoid these unexpected errors, it's probably better to do it now than later when more people use sc4pac.

@memo33
Copy link
Owner

memo33 commented Nov 18, 2024

I've removed a few images in cases where a STEX entry corresponds to multiple packages, to avoid showing unrelated images.

Also, it looks like the lastmodified timestamps mainly moved back in time, so sc4pac doesn't seem to trigger unnecessary re-downloads, as the cached files are already newer.

@memo33 memo33 merged commit 5039db9 into memo33:main Nov 18, 2024
3 checks passed
@sebamarynissen sebamarynissen deleted the feature/images branch November 18, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants