Add various metadata #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: we might still create separate packages for both the passenger and HSR replacements, to discuss.
Question about this: we only need some specific files from the mattb325 cruise terminal. Should it be listed as a dependency, or as an asset? We currently do both, but that doesn't seem like the way to go.
Add more metadata
Yes, I think it makes sense to split it into two packages, as that allows for choosing other train or monorail reskins individually in the future. The two packages can refer to each other in the description. |
memo33
reviewed
Nov 21, 2024
memo33
reviewed
Nov 22, 2024
|
Thanks for the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bunch of metadata as part of an effort to port most of my existing plugins folder to sc4pac (more to follow). Most of the metadata has been generated by a script that scrapes the Simtropolis url.
There's one thing I'd like to discuss. The
rivit:thalys-high-speed-trainactually contains two files: one to replace the passenger rail train, and one to replace the HSR train. Do you think it makes sense to split this into two separate packages?