-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Simmer2's content #50
base: main
Are you sure you want to change the base?
Conversation
Thanks a lot.
Yeah, I'd prefer moving them to a separate PR to make this one more manageable. You can squash the commits for simplicity. Reviewing 300 files at once is a bit much.
To explain this a little, my intention with that linting rule is to make it more inviting for anyone to edit the metadata, as the metadata is rarely written or updated by the original author of the STEX entry. It also avoids ambiguity as to who "I" refers to. |
Fyi, I moved a bunch of the dependencies to #51. You can focus on that one first. Once merged into main, I can update this branch from main and then those files should be gone from this PR. |
I updated the PR to reflect the changes from #51. Only 271 files left now. |
@memo33 I've added the complete list of packages I've added as json format in the first commend as a collapsed section. That way you can easily copy-paste it in your sc4pac-plugins.json file to test them, rather than having to type it all in manually. |
This PR adds most of Simmer2's content (250+ packages). I had to leave out a few ones due to dependencies not being available (for example, one package relies on a building made by WolfZe, other packages rely on SC4D LEX dependencies that are not yet available on SC4E).
A few things to note here:
sm2
, even though a package under the namesimmer2
already exists in the default channel. If you want me to change everything tosimmer2
, just let me know and I'll run a script that does this automatically.Some packages rely on dependencies from other PRs - most notably Add truck stops #48 - so the tests will fail as long as these PRs haven't been merged.Fixed since Add various dependencies #51.In order to add all this content, I had to add a few dependency packages that weren't available in the default channel too. If you want I can extract these into a separate PR so that the dependencies can be merged asap, while the review of Simmer2's actual content can take more time.See Add various dependencies #51.List of packages in json format