Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RRetail's content #54

Open
wants to merge 105 commits into
base: main
Choose a base branch
from

Conversation

sebamarynissen
Copy link
Contributor

@sebamarynissen sebamarynissen commented Dec 11, 2024

This PR adds all of RRetail's content, except for a few with unavailable dependencies. It also excludes a few relots that rely on a large amount of ancient dependencies, which I've deemed too many to include for now.

Filed as a draft PR for now because I still need to test them in game, and probably linting errors will need to be fixed as well. Tested in game, see comments below.

rretail

List of packages in json format
"rretail:ac-moore-arts-crafts",
"rretail:acme-market",
"rretail:afc-urgent-care",
"rretail:albertsons",
"rretail:aldi",
"rretail:ashley-homestore",
"rretail:aspen-dental",
"rretail:at-home",
"rretail:auto-zone",
"rretail:belk",
"rretail:best-buy",
"rretail:bi-lo-supermarket",
"rretail:bjs-wholesale-club",
"rretail:bon-ton",
"rretail:boscovs",
"rretail:boston-store",
"rretail:canadian-tire",
"rretail:car-wash-pack",
"rretail:carsons",
"rretail:chase-bank",
"rretail:child-world",
"rretail:cinemark",
"rretail:city-center-shopping-plaza",
"rretail:coastal-crossings-shopping-center",
"rretail:cub-foods",
"rretail:cvs-pharmacy",
"rretail:discount-tire-co",
"rretail:dollar-general",
"rretail:dollar-tree",
"rretail:downingtown-plaza",
"rretail:eastview-plaza",
"rretail:elder-beerman",
"rretail:family-dollar",
"rretail:family-dollar-tree",
"rretail:family-fare-supermarket",
"rretail:fifth-thirds-bank",
"rretail:firestone-auto-center",
"rretail:flying-j-truckstop",
"rretail:food-city",
"rretail:fred-meyer",
"rretail:gas-stations-pack-vol1",
"rretail:gas-stations-pack-vol2",
"rretail:gas-stations-pack-vol3",
"rretail:gateway-shopping-center",
"rretail:giant-eagle",
"rretail:giant-md-style",
"rretail:giant-pa-style",
"rretail:grand-central-plaza",
"rretail:h-e-b-braums-dairy",
"rretail:hannaford",
"rretail:harbor-freight-tools",
"rretail:harrison-hills-village-center",
"rretail:hh-gregg",
"rretail:hy-vee",
"rretail:ingles-market",
"rretail:jewel-osco",
"rretail:keybank",
"rretail:king-street-shopping-center",
"rretail:kmart-style-1",
"rretail:kmart-style-2",
"rretail:kmart-style-3",
"rretail:kmart-supercenter",
"rretail:kroger-marketplace-brands",
"rretail:lakeview-shopping-center",
"rretail:loves-truckstop",
"rretail:lowes",
"rretail:marketplace-boulevard",
"rretail:mavis-discount-tires",
"rretail:mega-prop-pack-vol1",
"rretail:mega-prop-pack-vol2",
"rretail:mega-prop-pack-vol3",
"rretail:meijer",
"rretail:meineke-car-care",
"rretail:midas-auto-care",
"rretail:monro-mufflerbrake",
"rretail:montgomery-wards",
"rretail:motel-6",
"rretail:msm-commercial-brands",
"rretail:msm-commercial-brands-models-props",
"rretail:msm-defunct-commercial-brands-pack",
"rretail:msm-health-education-services-pack",
"rretail:northtown-plaza",
"rretail:ollies-bargain-outlet",
"rretail:oreillys-auto-parts",
"rretail:otasco-store",
"rretail:park-place-plaza",
"rretail:pathmark",
"rretail:pep-boys",
"rretail:petsmart",
"rretail:pier-1-imports",
"rretail:pilot-truckstop",
"rretail:publix",
"rretail:ralphs",
"rretail:rite-aid",
"rretail:roadside-rest-area",
"rretail:ruler-foods",
"rretail:rural-king",
"rretail:sears-auto-center-large-version",
"rretail:sears-auto-center-small-version",
"rretail:sears-hometown-store",
"rretail:sears-recycled",
"rretail:shopko",
"rretail:shopko-hometown",
"rretail:shopko-recycled",
"rretail:shoprite",
"rretail:southside-shopping-center",
"rretail:staples",
"rretail:state-street-square",
"rretail:stop-and-shop-supermarket",
"rretail:strip-mall-1",
"rretail:strip-mall-2",
"rretail:strip-mall-3",
"rretail:strip-mall-4",
"rretail:strip-mall-5",
"rretail:strip-mall-6",
"rretail:suntrust-bank",
"rretail:super-kmart-recycled",
"rretail:target-style-2",
"rretail:the-home-depot",
"rretail:the-shops-at-simtropolis",
"rretail:tops-friendly-markets",
"rretail:toys-r-us-babies-r-us",
"rretail:tractor-supply-co",
"rretail:union-square-plaza",
"rretail:video-rental-stores",
"rretail:video-stores-recycled",
"rretail:village-crossroads-mall",
"rretail:vons-shopping-center",
"rretail:walgreens",
"rretail:walgreens-cooper-design",
"rretail:walmart",
"rretail:walmart-neighborhood-market",
"rretail:walmart-recycled",
"rretail:walmart-supercenter",
"rretail:wegmans",
"rretail:weis-markets",
"rretail:wells-fargo-bank",
"rretail:western-auto",
"rretail:western-dental",
"rretail:westgate-plaza",
"rretail:winco-foods-culvers",
"rretail:winn-dixie-supermarket",
"rretail:younkers",

@sebamarynissen
Copy link
Contributor Author

sebamarynissen commented Dec 13, 2024

Tested the lots in game, but I noticed that the creator has done a rather sloppy job in listing the dependencies. A lot of dependencies were not listed, but it's probably gone unnoticed because they are so common - stuff like bsc:texturepack-cycledogg-vol01 is quite common to have, but if you don't have it textures wouldn't show up for example for https://community.simtropolis.com/files/file/32405-younkers/.

I also had to exclude https://community.simtropolis.com/files/file/35468-meadowbrook-plaza/ due to brown boxes. I've investigated, but it looks like it's a "private model" that is missing that was not bundled with the package. I might upload a fix for this to the STEX and then I can re-include it.

Anyway, it's ready for review now @memo33, but I imagine it's going to take a while due to the amount of files.

@sebamarynissen sebamarynissen marked this pull request as ready for review December 13, 2024 14:13
@sebamarynissen
Copy link
Contributor Author

I added a fix for Meadowbrook Plaza to the STEX and included this as well in the metadata, so Meadowbrook Plaza is now included again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant