Provide more information to writedata callback. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…>source and new->target.
…revious record (original bsdiff produces records having both the first and second item zeroes, i.e. representing only a seek in the old file).
Cpp compatibility
Merging control records having zero in their first triplet with the p…
Forwards information about what data block is being written to writed…
Fixed previous merge.
C++ compatibility: "new" is reserved word in C++, thus I renamed old->source and new->target.
…into report-writetype
C++ compatibility: Added extern "C" for C++ code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwards information about what data block is being written to writedata() callback.
It does nothing for current implementation but it becomes very useful when using bsdiff as a library with custom stream processing.
The mendsley's implementation uses single interleaved data stream which has its advantages but creates larger patch files than vanilla bsdiff. This change allows us to easily generate both mendsley's and vanilla bsdiff patches as needed.
In addition, thanks to this change, it is possible to experiment with stream compression and use e.g. LZMA for extra data stream and keep bzip2 for control a diff streams. In my testing, this generates smallest possible patch files.