Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(governance-ui#40): add SeeAll component and Execution code view #42

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

AnnaJ-P11
Copy link
Contributor

@AnnaJ-P11 AnnaJ-P11 commented Jan 17, 2024

Description

Add a new component to Execution code view and implement it in create new proposal page and Single proposal view
Add SeeAll component to expanding views and implement it to Execution code and Proposal description

Other changes

n/a

Tested

PR build and lint successful

Related issues

Backwards compatibility

n/a

Documentation

n/a

@AnnaJ-P11 AnnaJ-P11 requested review from bowd and tplocic20 January 17, 2024 23:24
Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2024 7:45am

@bowd
Copy link
Contributor

bowd commented Jan 23, 2024

@AnnaJ-P11 The gradient isn't right for dark mode
image

@nvtaveras
Copy link
Contributor

@AnnaJ-P11 Gave it a try now in the last preview and the gradient looks good on dark mode but the preview execution code is not showing what I entered while creating the proposal, it shows the same placeholder as in Bogdan's screenshot:

Screenshot 2024-01-25 at 17 07 23

@bayological bayological merged commit d33ad44 into develop Jan 30, 2024
3 checks passed
@bayological bayological deleted the feat/40-expanding-and-execution-code-view branch April 17, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants