feat(governance-ui#35): Add proper data for Contract params on homepage #43
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bayological
requested review from
bayological and
nvtaveras
and removed request for
bayological
|
@bowd @bayological So, during the previous grooming session we talked about the implementation of SDK. To have one and unified way I can do this, but I need some guidance |
tplocic20
force-pushed
the
feat/35-governance-stats-component
branch
from
4358e2b to
b349e6c
Compare
There was a problem hiding this comment.
@tplocic20 I don't think we're there yet. Were you able to get the correct total veMento displayed in the UI?
I changed the locking contract address to 0x65a1271ce7B2ec8D564A4Bc752E13A36a46e81B8 which is correct for alfajores but I am still getting 0 as the total supply in the interface. The result of the read contract call is always undefined.
This is not the same as what I see on celo scan:
### Description It improves the chain state helper definition and loading and exposes a `useContracts` hook used throughout the app. The problem with this PR right now is that the addresses in the SDK are not the ones that are indexed in `The Graph` that is a separate deployment. I will migrate the indexers to this deployment as well. After I do that, however, we will have no test proposals because the ones that I created are on the other deployment. We need a small script to seed the deployment with some test proposals that have votes. ### Other changes - None ### Tested - Verified correct contract addresses were being used with logs on chain switch :) ### Related issues - Fixes #49
tplocic20
force-pushed
the
feat/35-governance-stats-component
branch
from
b349e6c to
a6b2c28
Compare
|
Fixed the total supply preview |
Description
Add a proper calculation of data for contract params view
Other changes
n/a
Tested
PR build and lint successful
Related issues
Backwards compatibility
n/a
Documentation
n/a