-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fetch & display governance params from mento sdk #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
denviljclarke
changed the title
feat: update null value handling
feat: fetch & display governance params from mento sdk
Jan 26, 2024
bayological
requested changes
Jan 29, 2024
nvtaveras
reviewed
Jan 29, 2024
nvtaveras
reviewed
Jan 30, 2024
Final update on this @bayological @nvtaveras.
|
bayological
reviewed
Feb 1, 2024
bayological
approved these changes
Feb 1, 2024
nvtaveras
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrate the Mento SDK into the app, using the new governance functions to fetch and display chain specific governance parameters on the front end.
One thing to note is that we need an overlay for when a wrong chain is connected, but I'm not sure how this should look, so I'll chat with @olenovyk about this, I think it's good to begin review as it is
Other changes
Updated the address shortening function to accept intended length as a param
Tested
PR build and lint successful
Related issues
Backwards compatibility
n/a
Documentation
n/a