Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch & display governance params from mento sdk #46

Merged
merged 7 commits into from
Feb 2, 2024

Conversation

denviljclarke
Copy link
Contributor

@denviljclarke denviljclarke commented Jan 25, 2024

Description

This PR integrate the Mento SDK into the app, using the new governance functions to fetch and display chain specific governance parameters on the front end.

One thing to note is that we need an overlay for when a wrong chain is connected, but I'm not sure how this should look, so I'll chat with @olenovyk about this, I think it's good to begin review as it is

Other changes

Updated the address shortening function to accept intended length as a param

Tested

PR build and lint successful

Related issues

Backwards compatibility

n/a

Documentation

n/a

Copy link

vercel bot commented Jan 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 6:01am

@denviljclarke denviljclarke marked this pull request as ready for review January 26, 2024 03:00
@denviljclarke denviljclarke changed the title feat: update null value handling feat: fetch & display governance params from mento sdk Jan 26, 2024
@philbow61 philbow61 self-requested a review January 29, 2024 16:47
@philbow61 philbow61 removed their request for review January 30, 2024 11:34
@denviljclarke
Copy link
Contributor Author

denviljclarke commented Jan 31, 2024

Final update on this @bayological @nvtaveras.

  1. As @olenovyk mentioned here, we'll display Celo information instead of an overlay
  2. I've also confirmed with Baran that the formatting for the quorum need and proposal threshold values are just 10*18 which I've done but I suspect we'll need to review it in the future once we have realistic number of tokens locked & veToken supply.

@denviljclarke denviljclarke merged commit 658346c into develop Feb 2, 2024
3 checks passed
@bayological bayological deleted the feat/fetch-gov-params-from-mento-sdk branch April 17, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants