[Deprecated] - Feat(28): Proposals creation - fields connection and cache

[tplocic20]

Status

Cherry picking features for Tailwind refactor context

Description

• Connected fields to contract
• Added json validation
• improved form state and navigation

Other changes

• Small change in validation and flows.

Tested

Go to proposal creation and fill data. The proposal should be created with filled info

Related issues

• Fixes Allow users to create a proposal and submit it on chain.  #28

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
governance-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 21, 2024 11:29am

[denviljclarke]

Hey @tplocic20 nice work, I just pulled this up locally I noticed a few small things -

• When a proposal is loaded from cache, I think it would be a great UX if users are automatically taken to the Proposal Description step.
• Similar to the Proposal Description step, it would be a good UX if the next button is disabled by default and disabled whenever there's an error.
• I know it’s not a part of this story but I’ve noticed that this section is missing

[tplocic20]

@denviljclarke

• When a proposal is loaded from cache, I think it would be a great UX if users are automatically taken to the Proposal Description step.

We need to start at the wallet step anyway, because there may be a chance that user is disconnected. But I will add auto "next" if the form is valid

• Similar to the Proposal Description step, it would be a good UX if the next button is disabled by default and disabled whenever there's an error.

Did you mean enabled by default and disabled on error?

• I know it’s not a part of this story but I’ve noticed that this section is missing

My bad - will add it

[denviljclarke]

Did you mean enabled by default and disabled on error?

Disabled by default (because by default it's invalid right right? because it's empty), like this

But when it's empty now the next button is still enabled.

What do you think?

[denviljclarke]

@denviljclarke

• When a proposal is loaded from cache, I think it would be a great UX if users are automatically taken to the Proposal Description step.

We need to start at the wallet step anyway, because there may be a chance that user is disconnected. But I will add auto "next" if the form is valid

Right, I understand. It did feel a bit weird not being able to continue where I left off as soon as I chose to. It might be better not to prompt users to continue until they've reached the Proposal Description step then?

[tplocic20]

Did you mean enabled by default and disabled on error?

Disabled by default (because by default it's invalid right right? because it's empty), like this

But when it's empty now the next button is still enabled.

What do you think?

The execution step is an optional value.
Contract is requiring some data there, but we do not expect user to fill it

[tplocic20]

@denviljclarke

Okay, so I've fixed issues you have mentioned.
Now, when user is coming back, and he is already connected (with enough veMENTO) - will be prompted about cache and redirected to the next step automatically.

The execution step is optional, so the next button is always available.

[bayological]

It would be good to run through this, for me this does not work locally.

1. When running locally, I get this error when I have clicked the create proposal page
   

2. When using the preview application the page loads fine however when using execution Json that does not match the specified format, if add a new line the error goes away but I cannot proceed
   Screencast from 03-12-2024 01:17:09 PM.webm

[RyRy79261]

I'm not able to access the /create-proposal page on vercel preview. Tried with Frame, Frame as Metamask & Metamask

[bayological]

When running locally the form defaults to the execution json section, leaving the title and description sections blank. Please check this out, it does not happen on the preview.

[bayological]

Some additional things I noticed:

The breadcrumb and title do not match what is on the figma design.

Current:

Figma:

The text displayed when a user doesn't have any locks should say:
"To create a new governance proposal, you need to lock 2,500 MENTO..."

Instead of:
"To create new governance proposal you need to lock 2,500 veMENTO."

[tplocic20]

Some additional things I noticed:

The breadcrumb and title do not match what is on the figma design.

Current:

Figma:

The text displayed when a user doesn't have any locks should say: "To create a new governance proposal, you need to lock 2,500 MENTO..."

Instead of: "To create new governance proposal you need to lock 2,500 veMENTO."

The breadcrumbs designs changed while working on this ticket and there is a separate task to update them.
I'll update the test shortly