fix: ensure 0 deltaFlow doesn't update state (#550)

mento-protocol · Nov 25, 2024 · 161ec08 · 161ec08
1 parent ea5d779
commit 161ec08
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/contracts/libraries/TradingLimits.sol b/contracts/libraries/TradingLimits.sol
@@ -128,6 +128,10 @@ library TradingLimits {
     int256 _deltaFlow,
     uint8 decimals
   ) internal view returns (ITradingLimits.State memory) {
+    if (_deltaFlow == 0) {
+      return self;
+    }
+
     int256 _deltaFlowUnits = _deltaFlow / int256((10 ** uint256(decimals)));
     require(_deltaFlowUnits <= MAX_INT48, "dFlow too large");
     require(_deltaFlowUnits >= MIN_INT48, "dFlow too small");

diff --git a/test/unit/libraries/TradingLimits.t.sol b/test/unit/libraries/TradingLimits.t.sol
@@ -259,6 +259,13 @@ contract TradingLimitsTest is Test {
     assertEq(state.netflowGlobal, 0);
   }
 
+  function test_update_withZeroDeltaFlow_doesNotUpdate() public {
+    state = harness.update(state, configL0L1LG(300, 1000, 1 days, 10000, 1000000), 0, 18);
+    assertEq(state.netflow0, 0);
+    assertEq(state.netflow1, 0);
+    assertEq(state.netflowGlobal, 0);
+  }
+
   function test_update_withL0_updatesActive() public {
     state = harness.update(state, configL0(500, 1000), 100 * 1e18, 18);
     assertEq(state.netflow0, 100);