Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: persist asset selection #143

Merged

Conversation

gabrieltemtsen
Copy link

Description

A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?

Added a "confirmView" to the redux state, so we can persist the formValues when a user clicks on the back button during a swap.

Other changes

Describe any minor or "drive-by" changes here.

Tested

An explanation of how the changes were tested or an explanation as to why they don't need to be.

Related issues

Checklist before requesting a review

  • [ -] I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • The PR title follows the conventions
  • I have run the regression tests

Copy link

vercel bot commented Oct 17, 2024

@gabrieltemtsen is attempting to deploy a commit to the Mento Labs Team on Vercel.

A member of the Team first needs to authorize it.

@gabrieltemtsen
Copy link
Author

Hi @bayological any word?

@bowd bowd requested review from bayological and RyRy79261 November 4, 2024 16:13
Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mento-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 8:48pm

@bayological
Copy link
Member

@gabrieltemtsen LGTM, let's get the branch updated and the checks passing

@gabrieltemtsen
Copy link
Author

Alright

@gabrieltemtsen
Copy link
Author

Hi @bayological the build error from the action is due to this ( unhandledRejection Error: No projectId found.)
if the repo could have the new Wallet Connect (now Reon) project ID --- it will pass.

@bayological bayological changed the title Feat/persist asset selection feat: persist asset selection Nov 6, 2024
@bayological
Copy link
Member

Hi @bayological the build error from the action is due to this ( unhandledRejection Error: No projectId found.) if the repo could have the new Wallet Connect (now Reon) project ID --- it will pass.

Np, secrets are only passed to the runner for PRs from collaborators. Will merge and close this. Thanks again 🙏

@bayological bayological enabled auto-merge (squash) November 6, 2024 20:52
@bayological bayological disabled auto-merge November 6, 2024 20:54
@bayological bayological merged commit 7ca9032 into mento-protocol:dev Nov 6, 2024
6 of 7 checks passed
@bayological bayological mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants