Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the placing of marks consistant for INSERT state. #675

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Haxxflaxx
Copy link
Contributor

@Haxxflaxx Haxxflaxx commented Nov 28, 2024

Update so that entering and exiting INSERT state will place marks the same way whether 'meow-select-on-*' variable is set or not. This includes adding configuration options for 'meow-open-*' functions.

The variables now only affect if the resulting mark should be active or not when exiting INSERT state.

This is to address #651

@DogLooksGood
Copy link
Collaborator

How about we use markers instead of just (point)?

@Haxxflaxx
Copy link
Contributor Author

I agree, after digging a bit deeper I found that this is handled by push-mark, so we can just pass the conditional into that.

I'm not really thrilled by my current implementation due to the double negation and I would prefer inverting it and let meow--select take an activate bool, but it would require updating every call to the function so I want to discuss this way of implementing it before doing the update.

Also I'm not sure what is failing in the CI for 26.3, is this something in my change that I introduced?

Update so that entering and exiting INSERT state will place marks the
same way whether 'meow-select-on-*' variable is set or not.
This includes adding configuration options for 'meow-open-*'
functions.

The variables now only affect if the resulting mark should be active
or not when exiting INSERT state.
@Haxxflaxx
Copy link
Contributor Author

I updated the signature for meow--select to take an activate argument. This makes it more in line with how push-mark works.

@DogLooksGood
Copy link
Collaborator

DogLooksGood commented Dec 16, 2024

Let me handle PRs one by one. Don't have too much time every day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants