Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation string in meow--parse-def #682

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

jixiuf
Copy link
Contributor

@jixiuf jixiuf commented Nov 30, 2024

Updated the documentation string in the meow--parse-def function to use buttonize for better context. This change improves the clarity of the message displayed when executing commands bound to a key, ensuring it correctly reflects the keybinding being used.

this close #677

Updated the documentation string in the `meow--parse-def` function to use `buttonize` for better
context. This change improves the clarity of the message displayed when executing commands bound to
a key, ensuring it correctly reflects the keybinding being used.
@DogLooksGood DogLooksGood merged commit 74fc0e5 into meow-edit:master Nov 30, 2024
0 of 3 checks passed
@DogLooksGood
Copy link
Collaborator

This PR breaks the linter, as buttonize is only available after 29.1

@jixiuf
Copy link
Contributor Author

jixiuf commented Dec 1, 2024

(propertize def
                                 'font-lock-face 'button
                                 'mouse-face 'highlight
                                 'follow-link t
                                 'category t
                                 'button-data (kbd def)
                                 'keymap button-map
                                 'action 'describe-key
                                 'button t)

can change that to this

@DogLooksGood
Copy link
Collaborator

Yeah. Have no idea how to bypass this lint.

Even if I introduce something like (version<= "29.1" emacs-version)

@jixiuf
Copy link
Contributor Author

jixiuf commented Dec 1, 2024

Yeah. Have no idea how to bypass this lint.

Even if I introduce something like (version<= "29.1" emacs-version)

(if (version<= "29.1" emacs-version)
                         (buttonize def 'describe-key (kbd def))
                       def)

(if (version<= "29.1" emacs-version)
                       def
         (buttonize def 'describe-key (kbd def)))

@jixiuf jixiuf deleted the help branch December 2, 2024 16:06
jidibinlin pushed a commit to jidibinlin/meow that referenced this pull request Jan 2, 2025
Updated the documentation string in the `meow--parse-def` function to use `buttonize` for better
context. This change improves the clarity of the message displayed when executing commands bound to
a key, ensuring it correctly reflects the keybinding being used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request ,make the *Help* buffer more useable
2 participants