feat(commands): add meow-pop-or-unpop-to-mark #690
Conversation
| @@ -1560,10 +1560,26 @@ To search backward, use \\[negative-argument]." | |||
| Before jump, a mark of current location will be created." | |||
| (interactive) | |||
| (meow--cancel-selection) | |||
| (unless (member last-command '(meow-pop-to-mark-command meow-unpop-to-mark-command)) | |||
| (unless (member last-command '(meow-pop-to-mark-command meow-unpop-to-mark-command meow-pop-or-unpop-to-mark)) | |||
There was a problem hiding this comment.
Aren't meow-pop-to-mark-command and meow-unpop-to-mark-command non-existent commands? I noticed this when I wrote #679, but didn't change it beacuse I thought about making a new PR.
There was a problem hiding this comment.
Introduced in e2ff708 by @DogLooksGood: did you mean to write meow-pop-to-mark and meow-unpop-to-mark, or was this just a typo?
There was a problem hiding this comment.
did you mean to write
meow-pop-to-markandmeow-unpop-to-mark, or was this just a typo?
Sorry, this was just to make an observation on something I thought could be an issue.
I'll open up a separate issue for this.
There was a problem hiding this comment.
(issue opened for this: #697)
|
What's the progress on this PR? |
It seems good to me, it's just that the reference to |
Oh, that's a typo; should have been |
Since `meow-search` allows us to search in the other direction using `-` (`negative-argument`), we should have similar behavior for the command that pops the mark: `-` will unpop the mark.
45mg
force-pushed
the
meow-pop-or-unpop-to-mark
branch
from
84c4141 to
5471d1a
Compare
meow-command.el
Outdated
|
|
||
| See also `meow-pop-or-unpop-to-mark-repeat-unpop'." | ||
| (interactive "p") | ||
| (if (or (and my/pop-or-unpop-mark-command-repeat-unpop |
There was a problem hiding this comment.
You forgot to remove the my/ prefix.
- (if (or (and my/pop-or-unpop-mark-command-repeat-unpop
+ (if (or (and meow-pop-or-unpop-to-mark-repeat-unpopThere was a problem hiding this comment.
Just this one needs to be fixed 👍
| @@ -1560,10 +1560,26 @@ To search backward, use \\[negative-argument]." | |||
| Before jump, a mark of current location will be created." | |||
| (interactive) | |||
| (meow--cancel-selection) | |||
| (unless (member last-command '(meow-pop-to-mark-command meow-unpop-to-mark-command)) | |||
| (unless (member last-command '(meow-pop-to-mark-command meow-unpop-to-mark-command meow-pop-or-unpop-to-mark)) | |||
There was a problem hiding this comment.
did you mean to write
meow-pop-to-markandmeow-unpop-to-mark, or was this just a typo?
Sorry, this was just to make an observation on something I thought could be an issue.
I'll open up a separate issue for this.
Since `meow-search` allows us to search in the other direction using `-` (`negative-argument`), we should have similar behavior for the command that pops the mark: `-` will unpop the mark. Co-authored-by: 45mg <[email protected]>
Since
meow-searchallows us to search in the other direction using-(negative-argument), we should have similar behavior for the command that pops the mark:-will unpop the mark.