[maple] Add 'Maple' (Sony Xperia XZ Premium) to fixup-mountpoints #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 30, 2018 20:17
Signed-off-by: Kristoffer Grundström <[email protected]>
Signed-off-by: Kristoffer Grundström <[email protected]>
Umeaboy
changed the title
Umeaboy
changed the title
Umeaboy
changed the title
|
I don't want to nag or sound negative, but can someone please merge this? I've been waiting for 2 years. |
|
You should squash the two commits to one and fix commit message formatting to "[maple] Add Sony Xperia XZ Premium to fixup-mountpoints" and also indentation in actual code changes is not correct, make sure indentation matches the other entries. No need to make a new pull request just do interactive rebase to squash the commits and amend the code changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kristoffer Grundström [email protected]